0

When should functional tests be run? Or is it always a good time to run functional tests?

3
  • 1
    Does this answer your question? Should I run the tests every time I review an open Bitcoin Core PR? Commented Apr 12 at 16:57
  • Not really. I would presume that the answer is to run test_runner.py as often as possible; the more the better? And if a test fails, what should I do?
    – Eoin
    Commented Apr 12 at 18:24
  • 2
    It depends what you're doing. If you aren't changing the code then running the tests repeatedly makes no sense. If you are opening a pull request with a code change in it then you can run the tests on your branch and check they pass before opening the pull request. If you are reviewing someone else's pull request branch then that link answers your question. Commented Apr 12 at 19:07

1 Answer 1

6

The functional tests are part of the test framework used for developing Bitcoin Core.

Developers will regularly run the functional tests, and other tests, when they are working on proposed changes to the code, to validate those changes. Which tests are helpful for that is up to the developer's judgment. Often significant changes will require changes or additions to the test framework too.

When a change is actually proposed, all tests (on a variety of platforms) are automatically performed by the CI (Continuous Intgration) infrastructure. Maintainers will not merge changes that do not pass all tests.

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Not the answer you're looking for? Browse other questions tagged or ask your own question.