0

I was looking through the pull requests on bitcoin core's github and was looking for some of the major changes to the code.

https://github.com/bitcoin/bitcoin/pulls?page=10&q=is%3Apr+is%3Aopen

The oldest one is from Feb 14, 2016 but I'm sure historically significant changes to the code were done since.

Any one know of any?

Does any one constantly (like everyday) review all commits outside of the bitcoin core team?

  • Note that your URL only searches for open PRs (= ones that have not been merged yet). Change to 'open' to 'merged' to see changes that were accepted into the repository. – Pieter Wuille Jan 2 '18 at 8:10
1

The oldest one is from Feb 14, 2016 but I'm sure historically significant changes to the code were done since.

Indeed, date opened is not always a good indication of controversy or significance, it could also mean a change which has received very little review due to its insignificance, or very little rebasing/nit-fixing due to lack of time by the creator. It's common for more important changes to be the focus of more urgent review allowing them to be merged sooner. Perhaps you should try sorting by number of comments or number of reactions, but even then it depends what you deem "significant".

Does any one constantly (like everyday) review all commits outside of the bitcoin core team?

By definition, someone who is actively involved in the review of PRs would be considered part of the "team". There is really no team, just volunteers, anyone is free to come and help out on GitHub, no requirements or prerequisites. Many users help out in this way, and you could be one of them :)

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.