This is more of a technical/programming question.
I am referring to this line of code: https://github.com/bitcoin/bitcoin/blob/be992701b018f256db6d64786624be4cb60d8975/src/net_processing.cpp#L1699
I understand the logic behind not sending a version packet to a newly
accepted connection unless they send one first, but the code I linked to does not quite do that, or does it?
At that point we are already inside an
if block which verifies that the command received is "version", so the peer has already sent us a version packet, irrespective of who initiated the connection. Am I missing something?