Bitcoin Stack Exchange is a question and answer site for Bitcoin users, developers, and enthusiasts. It only takes a minute to sign up.
Sign up to join this community
I'm studying Bitcoin Core currently. I found incomprehensible code, that shows making a transaction is rejected if there are same output addresses in a transaction.
See Fig1, Fig2
Origin source code : https://github.com/bitcoin/bitcoin/blob/8aac85d71e218783bc7ce06e5bf8bc660e24079d/src/rpc/rawtransaction_util.cpp#L95
So, the transaction illustrated in Fig1 will be rejected as shown Fig3.
Can you give reason about the policy of described in this post ?
It is not invalid.
The code you are looking it is unrelated to validation and relay of actual transactions. You are looking at the code for RPCs which are just things for users. The RPC disallows sending to an address multiple times because this is not efficient and usually a mistake by the user.
But this is only for creating a raw transaction using the Bitcoin Core RPC. A transaction received over the network or in a block that has dupllicate addresses in the outputs would not be rejected or be invalid in any way.
To expand on Andrew's answer a little, many application that interact with the Bitcoin network include some kind of "sane defaults". For Bitcoin Core, this is visible in the form of not allowing very high fee transactions, ensuring there aren't any duplicate addresses in outputs, attempting to use change addresses of the same type as the address you are sending coins to in an attempt to preserve privacy, and so on.
In many of these cases, these rules are different from the actual Bitcoin Protocol - For example, although Bitcoin Core tries to prevent absurdly high fees, there have been numerous cases of very high fee transactions (paying several BTC in fees) being mined.
Similarly, although the protocol allows multiple outputs to a single address, Bitcoin Core attempts to prevent that at an RPC level to reduce user error unintentionally costing them money. The Bitcoin Protocol itself has no rules against this, and will let you make such a transaction, and mine it, without any complaints.
