Questions tagged [bitcoincore-review]

collects guidance on how to effectively review and test open Bitcoin Core PRs.

Filter by
Sorted by
Tagged with
4 votes
1 answer
364 views

I would like to dig into the open Taproot PR to understand it, test it and possibly even review it. Any advice or recommendations?

I would like to dig into the open Taproot PR (PR #19953) to understand it, test it and possibly even review it. Any advice or recommendations?
Michael Folkson's user avatar
1 vote
1 answer
110 views

How do I build and review a Bitcoin Core GUI pull request?

I am a designer and I would like to start reviewing pull requests (PRs) in the Bitcoin Core GUI repository. How do I build the adjusted Bitcoin Core GUI in the pull request? I am used to just double ...
Michael Folkson's user avatar
6 votes
2 answers
293 views

How do I join the Bitcoin Core PR review club meetings on IRC?

I would like to learn about reviewing Bitcoin Core pull requests at the Bitcoin Core PR review club. How do I join the ##bitcoin-core-pr-reviews channel on IRC (Libera.Chat network) and which IRC ...
Michael Folkson's user avatar
4 votes
1 answer
440 views

How can I efficiently search the bitcoin-dev mailing list for discussion of a specific term?

How can I efficiently search the bitcoin-dev mailing list for discussion on a specific term e.g. deprecating BIP37 support? This question was asked by pinheadmz on IRC.
Michael Folkson's user avatar
1 vote
1 answer
248 views

I'm digging further into the open Taproot PR. Can you explain the BIP340 test vectors?

I'm digging further into the open Taproot PR. I found these BIP340 test vectors. They have secret keys, public keys, aux_rand (auxiliary randomness), message, signature and whether the signature ...
Michael Folkson's user avatar
1 vote
2 answers
303 views

What is ccache? When should I use it when building and reviewing Bitcoin Core PRs?

What is ccache? Can you provide some guidance on when to use it for building Bitcoin Core PRs and how to use it?
Michael Folkson's user avatar
0 votes
1 answer
107 views

How do I debug Taproot functional tests using pdb?

I am looking at the some of the Taproot functional tests such as feature_taproot.py to review the open Taproot PR. I would like to use pdb to debug these tests. Can you provide some guidance on how to ...
Michael Folkson's user avatar