What mistakes do first time contributors to Bitcoin Core often make with their first pull request?
asked Dec 27, 2020 at 18:26
Add a comment
|
1 Answer
The most common mistakes I have seen first time contributors make (and this includes me) is:
Not opening the PR from a topic branch of the forked Bitcoin Core repo and instead opening it from the master branch of the forked Bitcoin Core repo
Not adding the correct label at the start of the title of the PR
e.g.
doc: Address typo in file XNot squashing commits when there is no need for multiple commits
Opening a PR for individual typos without running the linter and finding additional typos
e.g.
./test/lint/lint-spelling.shOpening a PR for individual typos but not updating
test/lint/lint-spelling.ignore-words.txtto ignore false positives identified from running the linter.
answered Dec 27, 2020 at 18:26
-
This seems more appropriate in Bitcoin Core's developer documentation. I very much doubt Bitcoin SE is where people come looking for open-source contribution guidelines. Commented Dec 27, 2020 at 19:31
-
It is in the docs of the Core repo. But presumably because the docs are so long (can't be helped) new contributors don't follow the basics. Having this link to point to will save me typing the same thing over and over again :) Commented Dec 27, 2020 at 19:40
-
-
I'm sorry I don't know what you mean. I do link to the Core docs in this answer. If A links to B what is A and B in this context? Commented Dec 27, 2020 at 19:43
-
I just don't think Bitcoin SE is the best place to maintain this information. Commented Dec 27, 2020 at 19:46